Skip to content

Conversation

DominikB2014
Copy link
Contributor

  1. Migrates to new hook
  2. Several updates to the insight time series component to better utilize the hook (see comments in code)

@DominikB2014 DominikB2014 requested review from a team as code owners September 26, 2025 20:45
Copy link

linear bot commented Sep 26, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 26, 2025

yAxes.add(timeSeries.yAxis);

let alias = aliases?.[delayedTimeSeries.yAxis];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't always rely on the yAxis for alias. In the new timeSeries object, yAxis does not contain grouping information. To combat this I created formatTimeSeriesName, this is what the plottable now uses to generate it's name field, and we can also use that for the alias mapping.

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Sep 26, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11699 1 11698 10
View the top 1 failed test(s) by shortest run time
formatSeriesName other Formats "Other"
Stack Traces | 0.016s run time
ReferenceError: formatTimeSeriesName is not defined
    at Object.expect (.../timeSeriesWidget/formatters/formatTimeSeriesLabel.spec.tsx:160:7)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just trying to think more about simplifying this colour assignment logic, maybe there's a simpler way there

…of-usetopnspanseries-in-queues-http-and-mobile
@DominikB2014 DominikB2014 requested a review from a team as a code owner October 2, 2025 15:07
cursor[bot]

This comment was marked as outdated.

@DominikB2014
Copy link
Contributor Author

@gggritso I believe I made all updates that your requested, i confirmed that the colours are working as intended in the charts modified by this PR.
image
image

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@DominikB2014 DominikB2014 enabled auto-merge (squash) October 2, 2025 15:30
@DominikB2014 DominikB2014 merged commit de3fdd3 into master Oct 2, 2025
47 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/eng-5580-replace-usage-of-usetopnspanseries-in-queues-http-and-mobile branch October 2, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants