-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
remove useTopNSpanSeries
http, mobile and queue module
#100453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove useTopNSpanSeries
http, mobile and queue module
#100453
Conversation
DominikB2014
commented
Sep 26, 2025
- Migrates to new hook
- Several updates to the insight time series component to better utilize the hook (see comments in code)
|
||
yAxes.add(timeSeries.yAxis); | ||
|
||
let alias = aliases?.[delayedTimeSeries.yAxis]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't always rely on the yAxis
for alias
. In the new timeSeries
object, yAxis
does not contain grouping information. To combat this I created formatTimeSeriesName
, this is what the plottable now uses to generate it's name
field, and we can also use that for the alias
mapping.
static/app/views/insights/common/components/insightsTimeSeriesWidget.tsx
Outdated
Show resolved
Hide resolved
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
static/app/views/dashboards/widgets/timeSeriesWidget/plottables/continuousTimeSeries.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just trying to think more about simplifying this colour assignment logic, maybe there's a simpler way there
static/app/views/insights/common/components/insightsTimeSeriesWidget.tsx
Outdated
Show resolved
Hide resolved
static/app/views/insights/common/components/insightsTimeSeriesWidget.tsx
Outdated
Show resolved
Hide resolved
…of-usetopnspanseries-in-queues-http-and-mobile
@gggritso I believe I made all updates that your requested, i confirmed that the colours are working as intended in the charts modified by this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!