fix(aci): Return empty list from open periods endpoint when detector has no linked group #101046
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| {"detail": "Group not found. Could not query open periods."}, | ||
| status=status.HTTP_404_NOT_FOUND, | ||
| ) | ||
| return self.paginate(request=request, queryset=[]) |
There was a problem hiding this comment.
Bug: Missing Parameters in Paginate Call
The paginate call when target_group is not found (line 130) is missing paginator_cls, on_results, and count_hits. This results in inconsistent pagination and serialization behavior compared to the successful path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expected state, so IMO it should be a successful response with an empty list instead of a 404. This makes things simpler on the UI side.