Skip to content

Conversation

nsdeschenes
Copy link
Contributor

@nsdeschenes nsdeschenes commented Oct 7, 2025

This PR updates the combobox's so that they retain the users select position when multi-selecting items, and will sort the checked items to the top after they have closed and re-opened the combobox.

Ticket: EXP-357

Before:

Screen.Recording.2025-10-10.at.10.55.39.mov

After:

Screen.Recording.2025-10-10.at.11.00.48.mov

Copy link

linear bot commented Oct 7, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
12111 3 12108 10
View the top 3 failed test(s) by shortest run time
SearchQueryBuilder token values sets the value as not selected when no comma is present
Stack Traces | 0.598s run time
TestingLibraryElementError: Unable to find an accessible element with the role "checkbox" and name "Toggle randomValue"

Here are the accessible roles:

  grid:

  Name "Query Builder":
  ...

  --------------------------------------------------
  row:

  Name "browser.name:Firefox":
  ...

  --------------------------------------------------
  gridcell:

  Name "Firefox,randomValue":
  ...

  --------------------------------------------------
  combobox:

  Name "Edit filter value":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../components/searchQueryBuilder/index.spec.tsx:1859:30)
SearchQueryBuilder token values sets the value as selected when a trailing comma is present
Stack Traces | 0.781s run time
TestingLibraryElementError: Unable to find an accessible element with the role "checkbox" and name "Toggle randomValue"

Here are the accessible roles:

  grid:

  Name "Query Builder":
  ...

  --------------------------------------------------
  row:

  Name "browser.name:Firefox":
  ...

  --------------------------------------------------
  gridcell:

  Name "Firefox,randomValue, Hold Ctrl to select multiple Type to search suggestions Wildcard (*) matching allowed":
  ...

  --------------------------------------------------
  combobox:

  Name "Edit filter value":
  ...

  --------------------------------------------------
  separator:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  listbox:

  Name "Suggestions":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  group:

  Name "":
  ...

  --------------------------------------------------
  option:

  Name "Firefox":
  ...

  Name "Chrome":
  ...

  Name "Safari":
  ...

  Name "Edge":
  ...

  --------------------------------------------------
  paragraph:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  checkbox:

  Name "Toggle Firefox":
  ...

  Name "Toggle Chrome":
  ...

  Name "Toggle Safari":
  ...

  Name "Toggle Edge":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../components/searchQueryBuilder/index.spec.tsx:1878:30)
SearchQueryBuilder keyboard interactions selects the value when pressing enter after typing it in
Stack Traces | 0.862s run time
TestingLibraryElementError: Unable to find an accessible element with the role "checkbox" and name "Toggle randomValue"

Here are the accessible roles:

  grid:

  Name "Query Builder":
  ...

  --------------------------------------------------
  row:

  Name "browser.name:Firefox":
  ...

  --------------------------------------------------
  gridcell:

  Name "Firefox,randomValue":
  ...

  --------------------------------------------------
  combobox:

  Name "Edit filter value":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../components/searchQueryBuilder/index.spec.tsx:1721:30)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@nsdeschenes nsdeschenes requested a review from malwilley October 10, 2025 14:04
@nsdeschenes nsdeschenes marked this pull request as ready for review October 10, 2025 14:04
@nsdeschenes nsdeschenes force-pushed the nd/exp-357/fix-search-bar-multi-selecting-values-loses-position branch from a378715 to e30a48d Compare October 10, 2025 14:05
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant