Skip to content

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 9, 2025 00:35
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 9, 2025
<Section title={t('Resolve')}>
{tn(
'%s consecutive successful check.',
'%s successful check.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Pluralization in Check Messages

The pluralization for "failed check" and "successful check" messages is inconsistent. Singular forms now omit "consecutive" while plural forms retain it, leading to confusing messaging about check thresholds.

Fix in Cursor Fix in Web

Copy link

codecov bot commented Oct 9, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12154 1 12153 10
View the top 1 failed test(s) by shortest run time
DetectorDetails uptime detectors displays correct detector details
Stack Traces | 0.265s run time
TestingLibraryElementError: Unable to find an element with the text: 1 consecutive successful check.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByText (.../views/detectors/detail.spec.tsx:276:21)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants