Tweak Trigger: labels

[chadwhitacre]

Two changes:

1. Observe the Foo: Bar pattern. Use the aliases feature to rename. "For example, given the following config, GitHub Label Sync will look for labels on GitHub named either 'feature' or 'enhancement' then update them to match the newer config rather than deleting them."

2. Standardize colors. I recently introduced a Sync: Jira label, which seems loosely related to Trigger: . I propose using the same color for both types.

[github-actions]

🏷 The following changes will be made to the repository labels

Validating provided labels
Fetching labels from GitHub
 > Changed: the "trigger-getsentry-external" label in the repo is out of date. It will be updated to "Trigger: getsentry tests" with color "#A0CABD" and description "once code is reviewed: apply label to PR to trigger getsentry tests".
 > Changed: the "Trigger: Revert" label in the repo is out of date. It will be updated to "Trigger: Revert" with color "#A0CABD" and description "add to a merged PR to revert it (skips CI)".
 > Added: the "python" label in the repo is not expected. It will be deleted.
This is a dry run. No changes have been made on GitHub

[evanpurkhiser]

Good stuff, but whatever listens for this trigger will also need updated yes?

[chadwhitacre]

whatever listens for this trigger will also need updated yes?

Good call. Putting this in draft while I chase that down.

Any pointers, @asottile-sentry?

[chadwhitacre]

https://github.com/search?q=org%3Agetsentry+trigger-getsentry-external&type=code

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
sentry	🔄 Building (Inspect)		Dec 19, 2022 at 10:18PM (UTC)
storybook	🔄 Building (Inspect)		Dec 19, 2022 at 10:18PM (UTC)

[chadwhitacre]

whatever listens for this trigger will also need updated yes?

Done in 07adfc8.

[chadwhitacre]

Picked off another in getsentry/develop#795.

I believe that's it (except for sentry-test-repo, which is archived).

[evanpurkhiser]

Going to let @asottile-sentry approve this one 👍

[chadwhitacre]

We should probably pause the automation before landing this, so that the bot can update all the labels without triggering a bunch of unnecessary builds.

[chadwhitacre]

Yeah sorry I've been sitting on this, will try to make another push soon.

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[chadwhitacre]

it's going to trigger a bunch of runs

Can we remove the trigger-getsentry-external label from closed PRs? That would drastically minimize the problem. Right now there's only one open PR, for example, and if we accidentally trigger a new run on one or two PRs I think that's fine?

[asottile-sentry]

it's going to trigger a bunch of runs

Can we remove the trigger-getsentry-external label from closed PRs? That would drastically minimize the problem. Right now there's only one open PR, for example, and if we accidentally trigger a new run on one or two PRs I think that's fine?

yeah that'd probably work

[chadwhitacre]

Okay, let's do it! Label cleared. Need an approval here and then I will proceed.

[asottile-sentry]

[chadwhitacre]

Not sure why this is failing with a syntax error. The colon is quoted. Is it something else?

sentry/.github/workflows/getsentry-dispatch.yml

Line 22 in 02026f5

if: github.event.action != 'labeled' || github.event.label.name == 'Trigger: getsentry tests'

[asottile-sentry]

the whole string needs to be quoted -- otherwise yaml partially parses it as a mapping entity

[chadwhitacre]

Like this?

[asottile-sentry]

yeah that should work -- I think pre-commit run check-yaml --files .github/workflows/* will show that too iirc

[chadwhitacre]

$ pre-commit run check-yaml --files .github/workflows/* 
No hook with id `check-yaml` in stage `commit`
$

I looked through .pre-commit-config.yaml and don't find check-yaml.

[chadwhitacre]

Confirmed working on #44551.

https://github.com/getsentry/sentry/actions/runs/4439515190/jobs/7792079708?pr=45511

[asottile-sentry]

hmmm weird I could have sworn we had check-yaml