ref: fix type errors in sentry.incidents #72811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
joshuarli
reviewed
Jun 14, 2024
| for trigger_id, project_slug in AlertRuleTriggerExclusion.objects.filter( | ||
| alert_rule_trigger__in=item_list | ||
| ).values_list("alert_rule_trigger_id", "query_subscription__project__slug"): | ||
| exclusions = result[triggers[trigger_id]].setdefault("excludedProjects", []) |
joshuarli
approved these changes
Jun 14, 2024
asottile-sentry
force-pushed
the
asottile-typing-sentry-incidents
branch
from
415a6aa to
039cb96
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes errors when BaseManager becomes typechecked