Skip to content

ref: fix type errors in sentry.incidents #72811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ref: fix type errors in sentry.incidents #72811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/incidents/endpoints/serializers/alert_rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ def get_attrs(
order_by=F("date_added").desc(),
)
)
activations = alert_activations_ranked.filter(alert_rule__in=item_list, rank__lte=10)
activations_qs = alert_activations_ranked.filter(alert_rule__in=item_list, rank__lte=10)
activations_by_alert_rule_id = defaultdict(list)
for activation in activations:
for activation in activations_qs:
activations_by_alert_rule_id[activation.alert_rule_id].append(activation)

alert_rule_projects = set()
Expand Down
6 changes: 3 additions & 3 deletions src/sentry/incidents/endpoints/serializers/alert_rule_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ def serialize(self, obj, attrs, user, **kwargs):
class DetailedAlertRuleTriggerSerializer(AlertRuleTriggerSerializer):
def get_attrs(self, item_list, user, **kwargs):
triggers = {item.id: item for item in item_list}
result: DefaultDict[str, dict[str, list[str]]] = defaultdict(dict)
result: dict[str, dict[str, list[str]]] = defaultdict(lambda: defaultdict(list))
for trigger_id, project_slug in AlertRuleTriggerExclusion.objects.filter(
alert_rule_trigger__in=item_list
).values_list("alert_rule_trigger_id", "query_subscription__project__slug"):
exclusions = result[triggers[trigger_id]].setdefault("excludedProjects", [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol 🤔

exclusions.append(project_slug)
if project_slug is not None:
result[triggers[trigger_id]]["excludedProjects"].append(project_slug)
return result

def serialize(self, obj, attrs, user, **kwargs):
Expand Down