chore(issue ownership): Tests that groups with existing assignees are not reassigned #98750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98750 +/- ##
===========================================
+ Coverage 66.76% 81.25% +14.49%
===========================================
Files 8537 8546 +9
Lines 377146 377516 +370
Branches 24001 24001
===========================================
+ Hits 251804 306754 +54950
+ Misses 124977 70397 -54580
Partials 365 365 |
…sign groups that already have assignees
shashjar
changed the title
cvxluo
approved these changes
Sep 8, 2025
Comment on lines
1020
to
1021
| assert assignee is not None | ||
| assert assignee.user_id is None |
There was a problem hiding this comment.
nit, since i believe we're only really interested in verifying that team is set properly
Suggested change
| assert assignee is not None | |
| assert assignee.user_id is None |
There was a problem hiding this comment.
true, these are redundant
6 tasks
shashjar
deleted the
id-227-issue-owner-reordering-ownership-rules-changes
branch
shashjar
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Sep 8, 2025
…assigned (#14840) Resolves [ID-227](https://linear.app/getsentry/issue/ID-227/issue-owners-are-not-reordered-when-rules-are-reordered). Follow-up to [this PR](getsentry/sentry#98750). Updates the [Ownership Rules documentation](https://docs.sentry.io/product/issues/ownership-rules/) to clarify the intended behavior. Our post processing logic will never attempt to reassign a group if an assignee already exists, even if the cache has expired and/or the ownership rules have changed in the interim. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
… not reassigned (#98750) Resolves [ID-227](https://linear.app/getsentry/issue/ID-227/issue-owners-are-not-reordered-when-rules-are-reordered). We determined the bug reported in the above issue to be intended behavior. If a group already has an assignee, our post-processing logic will never attempt to reassign it when new events come in, even if the cache has expired and/or the ownership rules have changed in the interim. This PR adds a test to capture this behavior. [A separate PR](getsentry/sentry-docs#14840) has been created to update the [Ownership Rules](https://docs.sentry.io/product/issues/ownership-rules/) documentation page in order to make this behavior more explicit to users.
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ID-227.
We determined the bug reported in the above issue to be intended behavior. If a group already has an assignee, our post-processing logic will never attempt to reassign it when new events come in, even if the cache has expired and/or the ownership rules have changed in the interim.
This PR adds a test to capture this behavior. A separate PR has been created to update the Ownership Rules documentation page in order to make this behavior more explicit to users.