Skip to content

Commit e0eedf3

Browse files
committed
Fix: Set RPC error tags after request_id generation
Move _set_rpc_error_tags call to after __before_execute to ensure request_id is generated before setting Sentry tags. This prevents the request_id tag from being missing when clients don't provide one.
1 parent 484c5b0 commit e0eedf3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

snuba/web/rpc/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,9 @@ def execute(self, in_msg: Tin) -> Tout:
212212
in_msg=in_msg,
213213
query_id=uuid.uuid4().hex,
214214
)
215-
_set_rpc_error_tags(in_msg)
216215

217216
self.__before_execute(in_msg)
217+
_set_rpc_error_tags(in_msg)
218218
error: Exception | None = None
219219
meta = getattr(in_msg, "meta", RequestMeta())
220220
try:

0 commit comments

Comments
 (0)