-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix stray comma in function signatures in Metal #8311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this need backporting? |
@cwfitzgerald: I'm not @teoxoy, but I'll say: yesplz |
As far as we know it's only a CTS regression, right? I think backporting can at least wait for input from @teoxoy. |
I think newer Metal versions are fine with the stray comma since I couldn't repro this issue on my M1 either. |
e0691fb
to
c2adb99
Compare
I can put up another PR with the backport though. |
@cwfitzgerald I pushed on the remote instead of the origin (my fork) so it ended up directly in the v27 branch... is that ok? Or should I reset, force push and still open a separate PR? |
That's fine. I can bump version and release |
@teoxoy seems ci failed on v27. Could you investigate? |
@cwfitzgerald: I don't think this PR caused the CI failure; all failures report:
|
(The problem is that I bumped the CTS version on trunk earlier today, and the CTS is cloned with |
@andyleiserson: Filed #8313. |
Connections
Fixes Bug 1992500
Description
Fixes a regression introduced by #8265 where we were mistakenly writing a comma before the first buffer argument (if no other arguments were printed before it).
Testing
Enabled more CTS tests.
Squash or Rebase?
Rebase.