examples : switch retrieval to llama_encode#13685
Merged
Conversation
ggerganov
approved these changes
May 21, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Warmup calls llama_decode, would it make sense to disable this for embedding models somehow?
There isn't a simple criteria to do it. Is it causing issues?
Member
Author
No, just the |
infil00p
pushed a commit
to baseweight/llama.cpp
that referenced
this pull request
May 22, 2025
* switch retrieval to llama_encode * enable --no-warmup for retrieval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enable
--no-warmupoption for retrieval.Warmup calls
llama_decode, would it make sense to disable this for embedding models somehow?