Skip to content

Add support for DistilBert#13907

Merged
CISC merged 5 commits intoggml-org:masterfrom
huydt84:huydt/distill-bert
May 30, 2025
Merged

Add support for DistilBert#13907
CISC merged 5 commits intoggml-org:masterfrom
huydt84:huydt/distill-bert

Conversation

@huydt84
Copy link
Copy Markdown
Contributor

@huydt84 huydt84 commented May 30, 2025

Not that helpful, but this is support for DistilBert

@github-actions github-actions bot added the python python script changes label May 30, 2025
@huydt84
Copy link
Copy Markdown
Contributor Author

huydt84 commented May 30, 2025

@CISC please check again

@CISC
Copy link
Copy Markdown
Member

CISC commented May 30, 2025

Thanks, looks good, I'm sure this will be useful, I've seen a few dbert based models. :)

@huydt84
Copy link
Copy Markdown
Contributor Author

huydt84 commented May 30, 2025

On second thought, scratch that, we can change DistilBert to Bert arch and remove all this.

So will we do this, or keep DistilBert separated?

Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it, much cleaner this way.

@huydt84
Copy link
Copy Markdown
Contributor Author

huydt84 commented May 30, 2025

Remove it, much cleaner this way.

Done

@CISC CISC merged commit 291f2b6 into ggml-org:master May 30, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants