fix text spacing in print_info#18708
Conversation
|
Ooof, yes, and this was why... :) Since you're already touching the alignment everywhere AFAICR there are some conditionally printed ones that don't match. Edit: Ah yes, all the arch-specific ones. |
|
Are there some lines I missed? |
Not per se, but the arch-specific logs weren't aligned with the rest to begin with. |
|
Gotcha, I will take around look this evening and fix those as well. |
|
I think we can start to abstract this print into a new function, like: void print_info_item(const char * func_name, const char * item_name, ...) {
// get va_arg and format to string
LLAMA_LOG_INFO("%s: %-10s = %s", func_name, item_name, value_str);
}so if something is longer in the future, we just need to bump |
|
Aligned all the lines now. Tested on hybrid model (Jamba Mini), MoE (gpt-oss-120b), SWA (gemma-3-4b), and normal dense model (llama-3.3-70b). |
I'm fine either way, if you want to do it, I suggest doing it in this PR, if not we can merge this. |
|
I'll leave the abstraction for someone else in another PR. |
* fix text spacing in print_info * align all
* fix text spacing in print_info * align all
* fix text spacing in print_info * align all
* fix text spacing in print_info * align all
In the
print_info:output during model loading, there was a space missing afterrope_yarn_log_mul:Now it's fixed: