Skip to content

fix text spacing in print_info#18708

Merged
CISC merged 2 commits intoggml-org:masterfrom
ddh0:print-info-spacing
Jan 13, 2026
Merged

fix text spacing in print_info#18708
CISC merged 2 commits intoggml-org:masterfrom
ddh0:print-info-spacing

Conversation

@ddh0
Copy link
Copy Markdown
Contributor

@ddh0 ddh0 commented Jan 9, 2026

In the print_info: output during model loading, there was a space missing after rope_yarn_log_mul:

print_info: n_ctx_orig_yarn  = 131072
print_info: rope_yarn_log_mul= 0.0000
print_info: rope_finetuned   = unknown

Now it's fixed:

print_info: n_ctx_orig_yarn   = 131072
print_info: rope_yarn_log_mul = 0.0000
print_info: rope_finetuned    = unknown

@CISC
Copy link
Copy Markdown
Member

CISC commented Jan 9, 2026

Ooof, yes, and this was why... :)

Since you're already touching the alignment everywhere AFAICR there are some conditionally printed ones that don't match.

Edit: Ah yes, all the arch-specific ones.

@ddh0
Copy link
Copy Markdown
Contributor Author

ddh0 commented Jan 9, 2026

Are there some lines I missed?

@CISC
Copy link
Copy Markdown
Member

CISC commented Jan 9, 2026

Are there some lines I missed?

Not per se, but the arch-specific logs weren't aligned with the rest to begin with.

@ddh0
Copy link
Copy Markdown
Contributor Author

ddh0 commented Jan 9, 2026

Gotcha, I will take around look this evening and fix those as well.

@ngxson
Copy link
Copy Markdown
Contributor

ngxson commented Jan 9, 2026

I think we can start to abstract this print into a new function, like:

void print_info_item(const char * func_name, const char * item_name, ...) {
    // get va_arg and format to string
    LLAMA_LOG_INFO("%s: %-10s = %s", func_name, item_name, value_str);
}

so if something is longer in the future, we just need to bump %-10s to %-11s, etc

@ddh0
Copy link
Copy Markdown
Contributor Author

ddh0 commented Jan 10, 2026

Aligned all the lines now. Tested on hybrid model (Jamba Mini), MoE (gpt-oss-120b), SWA (gemma-3-4b), and normal dense model (llama-3.3-70b).

@ddh0
Copy link
Copy Markdown
Contributor Author

ddh0 commented Jan 13, 2026

@ngxson, @CISC

Will it be okay to merge like this to fix the immediate issue? Or do you want me to abstract it to a new function like ngxson said?

@CISC
Copy link
Copy Markdown
Member

CISC commented Jan 13, 2026

Will it be okay to merge like this to fix the immediate issue? Or do you want me to abstract it to a new function like ngxson said?

I'm fine either way, if you want to do it, I suggest doing it in this PR, if not we can merge this.

@ddh0
Copy link
Copy Markdown
Contributor Author

ddh0 commented Jan 13, 2026

I'll leave the abstraction for someone else in another PR.

@CISC CISC merged commit 6e36299 into ggml-org:master Jan 13, 2026
72 of 76 checks passed
dillon-blake pushed a commit to Boxed-Logic/llama.cpp that referenced this pull request Jan 15, 2026
* fix text spacing in print_info

* align all
@ddh0 ddh0 deleted the print-info-spacing branch February 20, 2026 18:17
MaheshJakkala pushed a commit to MaheshJakkala/llama.cpp that referenced this pull request Mar 15, 2026
* fix text spacing in print_info

* align all
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* fix text spacing in print_info

* align all
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* fix text spacing in print_info

* align all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants