sycl: implement GGML_OP_TRI#19089
Merged
NeoZhangJianyu merged 4 commits intoggml-org:masterfrom Jan 30, 2026
Merged
Conversation
github-actions
bot
added
ggml
Contributor
Author
|
Just checking in to see if you had a chance to look at this. |
Contributor
NeoZhangJianyu
left a comment
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
It's great!
Could you update the ops.md (https://github.com/ggml-org/llama.cpp/blob/master/docs/ops.md) for the supported OP?
Please refer to the guide in ops.md.
Thank you!
github-actions
bot
added
the
documentation
NeoZhangJianyu
approved these changes
Jan 29, 2026
Contributor
NeoZhangJianyu
left a comment
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
It's great work!
I will merge the PR after the CI is passed.
Contributor
Author
|
Fixed ops.md / CSV mismatch for GGML_OP_TRI. Latest commits are in; CI may need a re-run. |
Contributor
Author
|
The remaining CI failures appear unrelated to this PR:
All other checks are passing. |
CoraBlack
pushed a commit
to CoraBlack/llama.cpp
that referenced
this pull request
Jan 30, 2026
* sycl: implement GGML_OP_TRI * docs: update ops.md for SYCL TRI * docs: regenerate ops.md * docs: update SYCL support for GGML_OP_TRI
4b1tQu4ntN3k0
pushed a commit
to 4b1tQu4ntN3k0/llama.cpp
that referenced
this pull request
Feb 2, 2026
* sycl: implement GGML_OP_TRI * docs: update ops.md for SYCL TRI * docs: regenerate ops.md * docs: update SYCL support for GGML_OP_TRI
shaofeiqi
pushed a commit
to qualcomm/llama.cpp
that referenced
this pull request
Feb 6, 2026
* sycl: implement GGML_OP_TRI * docs: update ops.md for SYCL TRI * docs: regenerate ops.md * docs: update SYCL support for GGML_OP_TRI
electimon
pushed a commit
to electimon/llama.cpp
that referenced
this pull request
Mar 19, 2026
* sycl: implement GGML_OP_TRI * docs: update ops.md for SYCL TRI * docs: regenerate ops.md * docs: update SYCL support for GGML_OP_TRI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements GGML_OP_TRI for the SYCL backend (F32).
The implementation matches CPU semantics for all ggml_tri_type values
(lower/upper, with and without diagonal).
Tests:
Part of #14909