CUDA: add device number to error messages#3112
Merged
JohannesGaessler merged 1 commit intoggml-org:masterfrom Sep 11, 2023
Merged
CUDA: add device number to error messages#3112JohannesGaessler merged 1 commit intoggml-org:masterfrom
JohannesGaessler merged 1 commit intoggml-org:masterfrom
Conversation
Collaborator
|
This would be much more convenient than having to watch nvidia-smi closely to find out which GPU ran low first. |
slaren
approved these changes
Sep 10, 2023
Member
slaren
left a comment
slaren
left a comment
There was a problem hiding this comment.
Since errors may be caused by a previous asynchronous call, it might be a bit more accurate to only say what is the current device without making any claims about what device actually generated the error.
JohannesGaessler
force-pushed
the
cuda-check-print-device
branch
from
241d6bc to
496607d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when trying to fit a model onto multiple GPUs the error message only tells you that you are running out of memory, but not on which GPU which is a little inconvenient. But knowing which device is causing issues could also be useful debugging information in general. This PR makes it so that the CUDA error messages mention the device on which the error occurred.