make : restore build-info.h dependency for several targets#3205
Merged
cebtenzzre merged 2 commits intoggml-org:masterfrom Sep 18, 2023
Merged
make : restore build-info.h dependency for several targets#3205cebtenzzre merged 2 commits intoggml-org:masterfrom
cebtenzzre merged 2 commits intoggml-org:masterfrom
Conversation
Collaborator
Author
|
Could someone take a look at this? This issue is causing |
slaren
approved these changes
Sep 18, 2023
pkrmf
pushed a commit
to morlockstudios-com/llama.cpp
that referenced
this pull request
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in #2998, where make does not correctly generate build-info.h for some targets. These changes were originally part of an older implementation where print_build_info was a non-inline function and not a macro, and I forgot to remove them in the final version.