Merged
Conversation
Now the BERT tokenizer actually uses the SEP and CLS tokens from SpecialVocab.
When this is not set in HF `tokenizer_config.json`, it should default to true.
iamlemec
reviewed
Apr 5, 2024
iamlemec
approved these changes
Apr 5, 2024
Collaborator
Author
Since we were already writing cls_token_id and seperator_token_id to the GGUF, this should be fully backwards compatible with previous conversions of BERT models. Nomic BERT will not be backwards compatible due to the tensor shape change. |
ggerganov
approved these changes
Apr 8, 2024
vvhg1
added a commit
to vvhg1/llama.cpp
that referenced
this pull request
May 6, 2024
This reverts commit 1b67731.
vvhg1
added a commit
to vvhg1/llama.cpp
that referenced
this pull request
Jun 24, 2024
This reverts commit 82e6483.
vvhg1
added a commit
to vvhg1/llama.cpp
that referenced
this pull request
Jun 24, 2024
This reverts commit ae342c7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the conversion script:
Changes to llama.cpp tokenization: