Skip to content

Handle NotImplementedError in convert-hf-to-gguf#7660

Merged
Galunid merged 1 commit into
ggml-org:masterfrom
Galunid:clear-message
May 31, 2024
Merged

Handle NotImplementedError in convert-hf-to-gguf#7660
Galunid merged 1 commit into
ggml-org:masterfrom
Galunid:clear-message

Conversation

@Galunid
Copy link
Copy Markdown
Contributor

@Galunid Galunid commented May 31, 2024

Error message was not very user friendly since it was a whole stack trace. We raise this error when model is not yet supported, so stack trace can be replaced with nicer message instead of wall of text.

@github-actions github-actions Bot added the python python script changes label May 31, 2024
@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. labels May 31, 2024
@Galunid Galunid merged commit 0515ad9 into ggml-org:master May 31, 2024
@Galunid Galunid deleted the clear-message branch May 31, 2024 15:42
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants