cmake : Update to more modern version #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update from 3.0 (from 2014) to 3.19 (from 2020) - move some global setting onto the targets (through a cmake include)
asmaloney
force-pushed
the
cmake-update
branch
from
4f25d41 to
a578f04
Compare
Contributor
|
Debian Bullseye (the latest version) has CMake 3.18 by default, and this also affects Raspberry Pi's. So I recommend bumping the CMake version down to 3.18 |
ggerganov
added a commit
that referenced
this pull request
Jan 6, 2023
We increase the min version only when want to use particular functionality that is available in the newer version
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
- update from 3.0 (from 2014) to 3.19 (from 2020) - move some global setting onto the targets (through a cmake include)
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
We increase the min version only when want to use particular functionality that is available in the newer version
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
- update from 3.0 (from 2014) to 3.19 (from 2020) - move some global setting onto the targets (through a cmake include)
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
We increase the min version only when want to use particular functionality that is available in the newer version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's not possible to include whisper.cpp using
add_subdirectory()because it modifies the global cmake state (C++ version, install paths, etc.).This PR starts to move it towards a proper target-based approach.
I created a cmake include file to more easily set the defaults on the many examples, though it could just as well be copied into each file if you like.
I don't have a way to test the EMSCRIPTEN changes, but they mirror all the other examples.