Add enconding parameter to vocab.json opening to fix errors #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues on Windows 10 using the premade .bin files so I tried to use models/convert-pt-to-ggml.py to convert my existing OpenAI Whisper .pt files. However, it throws an error:
This is likely because my machine does not default to utf8 localization on Windows, but the legacy cp1252.
It was an easy fix of adding
enconding="utf8"toopen(dir_tokenizer + "/vocab.json", "r"). Works perfectly. Should fix other Windows setups as well and I can't see any drawbacks on other systems, OpenAI Whisper'svocab.jsonmost definitely is utf8.This is my first pull request ever, so apologies if my fork+add upstream+create branch+commit+push+pull request process is wrong. :)