opencl: fix concat crash on win arm64 with Adreno #15944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
lhez
force-pushed
the
concat-win-arm64-fix
branch
from
eaf86e3 to
cad982a
Compare
lhez
force-pushed
the
concat-win-arm64-fix
branch
from
cad982a to
b84d6ba
Compare
rmatif
approved these changes
Sep 21, 2025
struct
pushed a commit
to struct/llama.cpp
that referenced
this pull request
Sep 26, 2025
yael-works
pushed a commit
to yael-works/llama.cpp
that referenced
this pull request
Oct 15, 2025
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In concat, the data type for ne in the host code could be inconsistent with the kernels, depending
sizeof(long). It works fine on Android, Linux and Windows x64, but crashes on Windows arm64 with Adreno with -51 (CL_INVALID_ARG_SIZE). This PR usescl_longto make sure data type is consistent.