-
Notifications
You must be signed in to change notification settings - Fork 13.4k
ci : create git tags for released docker images #16008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0330443
to
182903d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automatic git tag creation for released Docker images. The purpose is to allow users to easily checkout the corresponding source code for any given Docker image by providing a git tag that matches the Docker image tag.
Key changes:
- Refactors tag determination logic to use a reusable action for generating source tag names
- Adds a step to create and push git tags when Docker images are published
When releasing a docker image for build number X, we should also create the corresponding git tag. This allows users to easily checkout the corresponding source tree for given docker image.
182903d
to
393e897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure if you can push a tag without setting permissions
though, have you tested it?
I don't know how to test such changes. Any help is appreciated. |
Apply the changes to |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
BTW, just checking, is your intention to just make sure that |
I want to make sure that we have The end goal is to have straightforward way to get the source tree for every docker image. |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
You probably want to cancel your |
You probably need to add |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Yes, it does work with the suggested changes, thanks for the help. I have also started the |
Both |
Yes, looks good, merge at will. |
* ci : create git tags for released docker images When releasing a docker image for build number X, we should also create the corresponding git tag. This allows users to easily checkout the corresponding source tree for given docker image. * Update .github/workflows/docker.yml Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Update .github/workflows/docker.yml Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Apply suggestion from @CISC Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
* ci : create git tags for released docker images When releasing a docker image for build number X, we should also create the corresponding git tag. This allows users to easily checkout the corresponding source tree for given docker image. * Update .github/workflows/docker.yml Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Update .github/workflows/docker.yml Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Apply suggestion from @CISC Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
When releasing a docker image for build number X, we should also create the corresponding git tag. This allows users to easily checkout the corresponding source tree for given docker image.