Skip to content

Conversation

@danbev
Copy link
Member

@danbev danbev commented Sep 24, 2025

This commit adds a leading slash to the paths of root-level files in the CODEOWNERS file.

The motivation for this is that these might otherwise match files in subdirectories that have other/additional owners will override them.

Refs: #16209 (comment)

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)
@danbev danbev requested a review from ggerganov September 24, 2025 06:07
@danbev danbev merged commit 4d9ea03 into ggml-org:master Sep 24, 2025
1 check passed
@danbev
Copy link
Member Author

danbev commented Sep 24, 2025

This looks correct now and I'm listed as the codeowner for examples/model-conversion/README.md 👍

@danbev danbev deleted the codeowners-root-paths branch September 24, 2025 06:14
pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request Sep 25, 2025
This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)
struct pushed a commit to struct/llama.cpp that referenced this pull request Sep 26, 2025
This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)
yael-works pushed a commit to yael-works/llama.cpp that referenced this pull request Oct 15, 2025
This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)
pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request Oct 23, 2025
This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants