add TheRock HIP backend build instructions #16915
Open
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Li <hao.li@amd.com>
github-actions
bot
added
the
documentation
CISC
reviewed
Nov 1, 2025
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
IMbackK
suggested changes
Nov 2, 2025
Collaborator
IMbackK
left a comment
IMbackK
left a comment
There was a problem hiding this comment.
So i think there are a couple of issues with this.
I think the instructions here should be more generic rather than focused on therock. Having instructions on how to use a rocm installation in a random folder to compile llamacpp is valuable, but i dont think we should be recommending people install a development preview of rocm as the first choice, thats asking for trouble.
I think this should be: use these cmake variables pointing to your rocm installation. The installation of rocm itself is out of scope for this document and we should just provide links to external documentation, with the offical amd provided binaries as the first mentioned method.
…link Signed-off-by: Hao Li <hao.li@amd.com>
…link Signed-off-by: Hao Li <hao.li@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add TheRock HIP backend build instructions