ci: Add openEuler-cann in build/release #17192
Conversation
|
@noemotiovon @hipudding Can you help review this pr？ |
github-actions
bot
added
the
devops
.devops/cann.Dockerfile
Outdated
|
|
||
| # Define the Ascend chip model for compilation. Default is Ascend910B3 | ||
| ARG ASCEND_SOC_TYPE=Ascend910B3 | ||
| ARG ASCEND_SOC_TYPE |
There was a problem hiding this comment.
ASCEND_SOC_TYPE can define chip type， CHIP_TYPE is not necessary?
.devops/cann.Dockerfile
Outdated
| # Define the CANN base image for easier version updates later | ||
| ARG CANN_BASE_IMAGE=quay.io/ascend/cann:8.1.rc1-910b-openeuler22.03-py3.10 | ||
| ARG CHIP_TYPE=910b | ||
| ARG CANN_BASE_IMAGE=quay.io/ascend/cann:8.1.rc1-${CHIP_TYPE}-openeuler22.03-py3.10 |
There was a problem hiding this comment.
Would CANN version 8.1 be a bit outdated?
There was a problem hiding this comment.
Yes, I will update it
.devops/cann.Dockerfile
Outdated
| # Use the passed ASCEND_SOC_TYPE argument and add general build options | ||
| RUN source /usr/local/Ascend/ascend-toolkit/set_env.sh --force \ | ||
| ARG CHIP_TYPE | ||
| ARG ASCEND_SOC_TYPE |
There was a problem hiding this comment.
ASCEND_SOC_TYPE can be inferenced by CHIP_TYPE.
There was a problem hiding this comment.
The modification has been completed.
|
Hi @ggerganov. We'd like to add releases for Ascend NPU, Can you please review this PR? Thanks. |
.github/workflows/release.yml
Outdated
| strategy: | ||
| matrix: | ||
| arch: [x86, aarch64] | ||
| device: ['ascend910b3', 'ascend310p3'] |
.github/workflows/release.yml
Outdated
| strategy: | ||
| matrix: | ||
| arch: [x86, aarch64] | ||
| device: ['ascend910b', 'ascend310p'] |
There was a problem hiding this comment.
nits: probably change this to chip_type to match the dockerfile params
There was a problem hiding this comment.
Ok, I have modified it.
There was a problem hiding this comment.
I mean the chip_type should not have the ascend prefix
There was a problem hiding this comment.
I made a mistake. Now it has been modified.
xuedinge233
force-pushed
the
test
branch
2 times, most recently
from
39dae72 to
3ede8a1
Compare
|
Please rebase to pass the CI. |
Update openEuler version Remove variable ASCEND_SOC_TYPE Modify the chip type Fix case in zip filename Change "device" to "chip_type" Modify the value of chip_type
|
It seems that resources for amd-rocm and amd-vulkan are tight. Considering that this is a release package for adding the CANN backend, it is therefore unrelated to those two use cases. |
This reverts commit ffa277a.
Update openEuler version Remove variable ASCEND_SOC_TYPE Modify the chip type Fix case in zip filename Change "device" to "chip_type" Modify the value of chip_type
6 participants
Make sure to read the contributing guidelines before submitting a PR