-
Notifications
You must be signed in to change notification settings - Fork 13.7k
ggml-cpu: handle 3d tensors in repack mat_mul #17241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ggml-cpu: handle 3d tensors in repack mat_mul #17241
Conversation
|
@max-krasnyansky can you please give this PR a shot and let me know if the perf is fixed? I've simplified a lot the chunking (essentially left it as it is for 2d tensors and "iterating" over planes) |
Yep. Looks great! Thanks for the quick followup. I'm marking it as ready to merge and approving. btw If you have some more time/energy it'd be great to add chunking to the repacked mul_mat_id for the MOE models. |
|
Thanks @max-krasnyansky. I'll be collaborating every now and then, but I have a couple of implementations of the repacked q4_K to address first. Not sure if you are able to merge, if not, I'll just ping gerganov once ci passes. Thanks again! Edit: Not sure if by marking "ready to merge" you meant to merge once ci passed |
I meant switching from "Draft" to "Ready" :) |
This is a continuation of #17030 after a performance regression was reported.
Perplexity Comparison (Repack vs Non-Repack)
Command:
Llama-bench
(M4 Max)
build: c77bafd (6967) THIS PR
build: 2776db6 (7047) MASTER