vulkan: implement ABS and NEG #17245
Merged
+14,618
−4,375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
implement-abs-neg
branch
from
47bd3d2 to
e5a59cd
Compare
Collaborator
|
LGTM. Has this come up in any networks? If so, we should consider fusing it. |
jeffbolznv
approved these changes
Nov 13, 2025
Contributor
Author
no, I was just looking at |
github-actions
bot
added
documentation
giuseppe
force-pushed
the
implement-abs-neg
branch
from
e5a59cd to
2fb905c
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
implement-abs-neg
branch
from
2fb905c to
0165f1f
Compare
Contributor
Author
|
rebased to solve conflicts |
basnijholt
pushed a commit
to basnijholt/llama.cpp
that referenced
this pull request
Nov 16, 2025
* docs: update Vulkan ops * vulkan: add NEG op * vulkan: add ABS op --------- Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.