Skip to content

Conversation

@taronaeo
Copy link
Collaborator

fixes #17229

Enables storing of symlink information in the archive to avoid duplicating libraries such as *.dylib. Saves on storage space and bandwidth.

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
@taronaeo taronaeo requested a review from slaren as a code owner November 16, 2025 11:55
@taronaeo taronaeo requested review from CISC and removed request for slaren November 16, 2025 11:55
@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 16, 2025
@CISC
Copy link
Collaborator

CISC commented Nov 16, 2025

Have you tested the archives on various platforms? AFAIK there are several issues with symlinks in zip.

@taronaeo
Copy link
Collaborator Author

Tested this on an M1 MacBook Pro and it worked as intended. Any specific OS I should test this on?

I can try to spin up VMs to test this coming weekend.

@taronaeo
Copy link
Collaborator Author

Also, i feel like it would be a better idea to incrementally move to .tar.gz for Linux releases and keep .zip for Windows. WDYT?

@CISC
Copy link
Collaborator

CISC commented Nov 17, 2025

Windows in particular would be nice to confirm still works.

Moving to tar (not necessarily gzip) on Linux makes sense, not sure why we're using zip?

@CISC CISC requested a review from slaren November 17, 2025 08:41
@taronaeo
Copy link
Collaborator Author

Windows in particular would be nice to confirm still works.

Will test it this weekend and report back.

Moving to tar (not necessarily gzip) on Linux makes sense, not sure why we're using zip?

Sweet. I'll start including .tar archives in this PR and maybe we can put a deprecation warning somewhere (maybe README.md?) to inform that Linux releases will be moving to .tar instead of .zip.

Then maybe after a few months, we can officially deprecate .zip for Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: Regression: distribution contains duplicate dylibs (macOS)

2 participants