vulkan: add log RTE support to fix Nvidia CI #17320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbolznv
reviewed
Nov 17, 2025
ggml/src/ggml-vulkan/ggml-vulkan.cpp
Outdated
| ggml_vk_create_pipeline(device, device->pipeline_log[1], "log_f16", log_f16_len, log_f16_data, "main", 2, sizeof(vk_op_unary_push_constants), {512, 1, 1}, {}, 1); | ||
|
|
||
| if (device->float_controls_rte_fp16) { | ||
| ggml_vk_create_pipeline(device, device->pipeline_log[0], "log_f32_rte", log_f32_len, log_f32_data, "main", 2, sizeof(vk_op_unary_push_constants), {512, 1, 1}, {}, 1); |
Collaborator
There was a problem hiding this comment.
This isn't picking the rte shader?
github-actions
bot
added
Vulkan
jeffbolznv
approved these changes
Nov 17, 2025
Collaborator
|
I think this can be merged without waiting for the remaining CIs... |
ronaldmannak
pushed a commit
to PicoMLX/llama.cpp
that referenced
this pull request
Nov 19, 2025
* vulkan: add log RTE support to fix Nvidia CI * actually use the rte shader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.