Skip to content

Conversation

@ggerganov
Copy link
Member

Noticed that all /src/models/* were accidentally being ignored

@ThiloteE
Copy link
Contributor

ThiloteE commented Nov 18, 2025

By default, the git index (roughly?) duplicates everything in the repo, which might lead to a situation where unsuspecting users that update to a version of llama.cpp with this change, require more storage capacity to store the repo (and the models) than is currently available. This was likely the reason why /src/models/* was added to gitignore in the first place. If anything, I would announce this as a breaking change.

@ggerganov
Copy link
Member Author

No, the problem was that models/* ignores not just models/* but also src/models/*. The latter was never intended.

@ThiloteE
Copy link
Contributor

Oh, you are right! Sorry for the noise.

@ggerganov ggerganov merged commit f40a2e5 into master Nov 18, 2025
3 checks passed
@ggerganov ggerganov deleted the gg/gitignore-update branch November 18, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants