vulkan : fix FA mask load with bounds check (coopmat2) #17606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acly
requested review from
0cc4m and
jeffbolznv
and removed request for
0cc4m
jeffbolznv
approved these changes
Nov 29, 2025
Collaborator
jeffbolznv
left a comment
jeffbolznv
left a comment
There was a problem hiding this comment.
LGTM. I had initially written the new logic inside the ifs, but when cleaning it up I guess I missed this.
github-actions
bot
added
Vulkan
Collaborator
|
@pwilkin Why did you merge it? Please leave merging to the people involved in the PR or the code that it touches, especially when reviews are still open. |
Collaborator
|
@0cc4m sorry, I though since @jeffbolznv approved then that was the end of the review process, my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was caused by variable shadowing in flash_attn_cm2, introduced in #17186
It was only observable with coopmat2 and
GGML_KQ_MASK_PAD=1Repro:
ggml.hand setGGML_KQ_MASK_PAD 1test-backend-ops-o FLASH_ATTN_EXT