Skip to content

memory is not guaranteed to be aligned properly during ggml_init call from loading saved sessions #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2023
Merged

memory is not guaranteed to be aligned properly during ggml_init call from loading saved sessions #1934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ced8e8d
fixed issue: memory is not guaranteed to be aligned properly during g…
l3utterfly Jun 19, 2023
2f9366b
- removed commented out old code from fix
l3utterfly Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions llama.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3122,9 +3122,7 @@ size_t llama_copy_state_data(struct llama_context * ctx, uint8_t * dst) {
if (kv_size) {
const size_t elt_size = ggml_element_size(kv_self.k);

char buffer[4096];

ggml_context * cpy_ctx = ggml_init({ sizeof(buffer), buffer, /* no_alloc */ true });
ggml_context * cpy_ctx = ggml_init({ 4096, NULL, /* no_alloc */ true });
ggml_cgraph gf{};
gf.n_threads = 1;

Expand Down Expand Up @@ -3230,9 +3228,7 @@ size_t llama_set_state_data(struct llama_context * ctx, uint8_t * src) {

const size_t elt_size = ggml_element_size(kv_self.k);

char buffer[4096];

ggml_context * cpy_ctx = ggml_init({ sizeof(buffer), buffer, /* no_alloc */ true });
ggml_context * cpy_ctx = ggml_init({ 4096, NULL, /* no_alloc */ true });
ggml_cgraph gf{};
gf.n_threads = 1;

Expand Down