Skip to content

[SYCL] Update get version #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

[SYCL] Update get version #6025

merged 1 commit into from
Mar 13, 2024

Conversation

AidanBeltonS
Copy link
Contributor

This PR updates the get_version implementation in the DPCT headers to work with AMD GPUs.
As is AMD GPUs crash with error:

terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted

This is a problem in the DPCT headers, I have already raised the issue upstream.
oneapi-src/SYCLomatic#1779

@AidanBeltonS
Copy link
Contributor Author

@abhilash1910, @airMeng, @OuadiElfarouki, feedback welcome

wenhuiNi
wenhuiNi approved these changes Mar 13, 2024
View reviewed changes
Copy link

@wenhuiNi wenhuiNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can create a pr to DPCT/SYCLomatic repo. Upstream this fix pr directly.

@abhilash1910
Copy link
Contributor

@AidanBeltonS could you please rebase to latest master?

@abhilash1910 abhilash1910 mentioned this pull request Mar 13, 2024
Closed
@abhilash1910 abhilash1910 merged commit b3d9786 into ggml-org:master Mar 13, 2024
@NeoZhangJianyu
Copy link
Collaborator

@AidanBeltonS
The code indentation is 2, but it's required 4.

@airMeng
Copy link
Contributor

airMeng commented Mar 15, 2024

@AidanBeltonS The code indentation is 2, but it's required 4.

shall we apply clang-format for sycl part?

NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 15, 2024
@AidanBeltonS @NeoZhangJianyu
Update get version (ggml-org#6025)
463ab3e
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
@AidanBeltonS @hodlen
Update get version (ggml-org#6025)
0fb4225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@abhilash1910 abhilash1910 abhilash1910 approved these changes

@wenhuiNi wenhuiNi wenhuiNi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AidanBeltonS @abhilash1910 @NeoZhangJianyu @airMeng @wenhuiNi