Skip to content

rpc : set SO_REUSEADDR for the server socket #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2024
Merged

rpc : set SO_REUSEADDR for the server socket #7320

merged 1 commit into from
May 17, 2024

Conversation

@rgerganov
Copy link
Collaborator

@rgerganov rgerganov commented May 16, 2024

ref: #7293

@rgerganov
Copy link
Collaborator Author

rgerganov commented May 16, 2024

This patch fixes the problem of not being able to restart rpc-server on the same port if it crashes.

This can be verified like this:

  1. start rpc-server -p 50052
  2. in some other console nc localhost 50052
  3. killall -9 rpc-server

If you try to start rpc-server again (without SO_REUSEADDR), it will fail. With this patch, it will start successfully.

@rgerganov rgerganov mentioned this pull request May 16, 2024
Closed
@mofosyne mofosyne added server Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 16, 2024
@rgerganov rgerganov merged commit f4bd8b3 into ggml-org:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rgerganov @ggerganov @mofosyne