Skip to content

Conversation

ggoss7
Copy link
Owner

@ggoss7 ggoss7 commented Oct 10, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@mandana-g mandana-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Grace, your assignment 1 is approved. Just a few notes for improvement:

  1. In section 2 of Part 2, the print statements output None because the function call isn’t wrapped with a print. Show actual expected outputs in comments or print results to validate.

  2. In section 6 of part2, there is an incorrect time complexity claim: repeated deletion of pairs using Python lists or strings is O(n²) in the worst case, not O(n).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants