Skip to content

bug fix for handling of server error messages #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from Dec 14, 2017
Merged

bug fix for handling of server error messages #111

merged 8 commits into from Dec 14, 2017

Conversation

@ghost
Copy link

@ghost ghost commented Sep 25, 2017

See issue #109

@ghost ghost mentioned this pull request Sep 25, 2017
Closed
@coveralls
Copy link

coveralls commented Sep 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 87.918% when pulling 98e1341 on GNSSYSTEMS-tg:patch-1 into 17ae489 on ghidoz:master.

@ghost
Copy link
Author

ghost commented Sep 26, 2017

Implemented this.

@coveralls
Copy link

coveralls commented Sep 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 87.626% when pulling 04beb1d on GNSSYSTEMS-tg:patch-1 into 17ae489 on ghidoz:master.

@coveralls
Copy link

coveralls commented Sep 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 87.626% when pulling e64af4f on GNSSYSTEMS-tg:patch-1 into 17ae489 on ghidoz:master.

HennerM
HennerM reviewed Sep 27, 2017
View reviewed changes
src/services/json-api-datastore.service.ts Outdated

return Observable.merge(
modelObservable
.filter(res => res.errors),
Copy link
Collaborator

@HennerM HennerM Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does the errors property come from. Isn´t the type of modelObservable Observable<T>?

@ghost
Copy link
Author

ghost commented Oct 27, 2017

Please verify - this is an important feature for my application.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 87.811% when pulling 966cfff on GNSSYSTEMS-tg:patch-1 into 7980fa0 on ghidoz:master.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 88.03% when pulling edd9497 on GNSSYSTEMS-tg:patch-1 into 7980fa0 on ghidoz:master.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.0% when pulling 220557e on GNSSYSTEMS-tg:patch-1 into 7980fa0 on ghidoz:master.

@hpawe01 hpawe01 mentioned this pull request Nov 23, 2017
Closed
@aimcom aimcom mentioned this pull request Dec 14, 2017
Closed
@HennerM HennerM merged commit 5b58528 into ghidoz:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coveralls @HennerM