Skip to content

Conversation

@abrararshad
Copy link
Contributor

Below line in the attribute decorate makes it impossible to patch an attribute that may have come as undefined from the server. New value was never taken into consideration

const propertyHasDirtyAttributes = typeof oldValue === 'undefined' && !isNew ? false : hasDirtyAttributes;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.194% when pulling bb1bfdf on abrararshad:patching_undefined_attribute into 68fb942 on ghidoz:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.194% when pulling bb1bfdf on abrararshad:patching_undefined_attribute into 68fb942 on ghidoz:master.

@HennerM HennerM merged commit c2ddfcc into ghidoz:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants