Skip to content

Conversation

@jacobbullock
Copy link
Contributor

fixes #183

it might be worth considering moving transformSerializedNamesToPropertyNames into the model class. For now i needed to make that method public so the model can access it.

@coveralls
Copy link

coveralls commented Jun 6, 2018

Coverage Status

Coverage remained the same at 90.443% when pulling e009a24 on jacobbullock:update-serialized-attributes into ac228bc on ghidoz:master.

@safo6m
Copy link
Collaborator

safo6m commented Nov 6, 2018

fixes #183

it might be worth considering moving transformSerializedNamesToPropertyNames into the model class. For now i needed to make that method public so the model can access it.

I agree. I'm accepting the current change for now.

@safo6m safo6m merged commit aa419a9 into ghidoz:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serializedName not used when updating object in data store

3 participants