Add check arguments to save model method #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safo6m
reviewed
Jul 18, 2019
| public save(params: {[s: string]: any}, customUrl: string): Observable<this>; | ||
| public save(headers: HttpHeaders, customUrl: string): Observable<this>; | ||
| public save(params: {[s: string]: any}, headers: HttpHeaders, customUrl: string): Observable<this>; | ||
| public save(...args: any[]): Observable<this> { |
Collaborator
There was a problem hiding this comment.
I would rather have a single argument instead of this type checking.
something like:
public save(options: SaveRequestOptions): Observable<this>;
@iamruslanbakirov what do you think about that?
Author
There was a problem hiding this comment.
Maybe you right, but typescript has overloading and it's great feature for this cause. And I saw same implementation in AngularJS.
so, when you have only one parameter you should be again and again create options object. it's bored 😑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be very convenient to use the save method with a different set of arguments.
Added overload.