Restructure angular library #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry to anyone who has to git-blame through this
Angular >=8 only supports LTS and up
safo6m
requested changes
Sep 16, 2019
Collaborator
safo6m
left a comment
safo6m
left a comment
There was a problem hiding this comment.
Thanks for the pull request.
@magneticflux- can you change the base branch to release-v8 for easier maintaining the old and the new version?
projects/angular2-jsonapi/src/converters/json-model/json-model.converter.spec.ts
Outdated
Show resolved
Hide resolved
magneticflux-
commented
Sep 16, 2019
safo6m
approved these changes
Sep 17, 2019
Collaborator
safo6m
left a comment
safo6m
left a comment
There was a problem hiding this comment.
@magneticflux- Great, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@safo6m #241 (comment)
Here's my refactoring attempt!
It includes the test for cyclic HasMany relationships, but it is ignored using
xit(...) { ... }.I'll rebase my other PR on this when it's acceptable to you and merged, and re-enable it there to work on fixing the issue.
Also, if possible, you should enable Travis CI for this repository since it has a working.travis.yml.Actually, I think it needs to be migrated to the
.comdomain from the old.orgdomain; resources for that are here, here, and here.