[BUGFIX] #244 Fix removing belongsTo relations

[frans-beech-it]

No description provided.

[coveralls]

Coverage decreased (-0.6%) to 90.995% when pulling 20e8b93 on frans-beech-it:244-fix-removing-belongsTo-relation into 5c2ede1 on ghidoz:master.

[frans-beech-it]

related to #148

[n2ygk]

@frans-beech-it I am experiencing this issue as well. I have what I think is a very common use case in which the parent model has an optional singular child relationship. My use case is that I add a relationship and then want to remove it which I do by setting relationship to null. The resulting PATCH payload leaves it out rather than setting it to "rel_name": {"data": null} per the JSONAPI spec

I'm guessing this PR is because progress stalled on #148?

[fsaris]

I'm not sure if #148 is still relevant. But my pr resolves this issue. You can try is in your own project by pasting the 2 methods touched in this PR in your own datastore service.

Will try to add some tests to this soon so hopefully this can be merged.

[n2ygk]

I'm not sure if #148 is still relevant. But my pr resolves this issue. You can try is in your own project by pasting the 2 methods touched in this PR in your own datastore service.

Will try to add some tests to this soon so hopefully this can be merged.

@fsaris Yep, grabbed getRelationships and updateRelationships and it works great. Thanks!

[n2ygk]

@fsaris @frans-beech-it Any progress on merging this?

[bosk59]

Waiting for a merge too....

[frans-beech-it]

@HennerM @hpawe01 what is needed to get this merged?

[hpawe01]

@HennerM @hpawe01 what is needed to get this merged?

I don't have merge permissions, so I guess you meant only @HennerM?

[HennerM]

I am afraid I can't maintain this repo anymore. It would be best if you could talk to @ghidoz about transfering ownership.

[fsaris]

@HennerM tnx for merging

[fsaris]

I am afraid I can't maintain this repo anymore. It would be best if you could talk to @ghidoz about transfering ownership.

Please let me know if you need someone to help here

[ghidoz]

I am afraid I can't maintain this repo anymore. It would be best if you could talk to @ghidoz about transfering ownership.

Please let me know if you need someone to help here

@fsaris sorry, I missed the mention. Are you still interested in managing the project? I can add you as a collaborator

[fsaris]

@fsaris sorry, I missed the mention. Are you still interested in managing the project? I can add you as a collaborator

Sounds good 👍🏼