-
Notifications
You must be signed in to change notification settings - Fork 122
Add parse meta data from http #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
looks good to me! |
src/models/json-api-query-data.ts
Outdated
| @@ -0,0 +1,14 @@ | |||
| import {JsonApiModel} from './json-api.model'; | |||
|
|
|||
| export class JsonApiQueryData { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this class generic too? thus the need for a typecast when using getModels() would be obsolete.
Besides of this little change the PR LGTM ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did you meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready! 1b269e7
|
@HennerM can you approve my merge request? |
|
Looking for a merge on this... @ghidoz? |
|
Thanks for your work. |
|
I would also appreciate having an "official" fork of this library so we can merge the PRs of the contributors and fix some of the open issues. |
|
Any updates on this issue? When will this be implemented? |
|
@HennerM unfortunately I was really busy in the last months and I had no time to review the PRs and maintain the package. If you are interested and you have the time, I can make you admin. What do you think? |
|
@HennerM that would be great! |
|
Awesome! @HennerM I added you as a collaborator on this project. What is your username on NPM? |
|
Great, thank you very much. My npm username is "hennerm" as well. I will try to go through the issues and PR in the next weeks. If there are other people with more spare-time on their hands I am keen for joining forces, since I am kind of busy in the next days. |
|
Cool! You are a collaborator also on NPM now. Thanks and let me know if you need to add more collaborators. |
|
Thanks @ghidoz |
|
It says your invitation is pending. I think you should accept it @HennerM |
|
Yeah I see now, thank you! |
#26
Now we can use
then
and if we use
.findAllwe need to use it right that:We can define any metadata what we need in JsonApiMetaModel like links and provide it in annotation to model class