Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

- when there is no more column to sort, we could resort by default sort id which would display dataset the way it was when it was first loaded
- ref SO question: https://stackoverflow.com/questions/62489108/angular-slickgrid-column-wise-remove-sort-option-not-working-properly
- also found that Clear Column Sort on a Local Grid was not trigger a "sortChanged" event while it should so that the Grid State is also notified
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #509 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #509    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9578      9586     +8     
  Branches      3202      3342   +140     
==========================================
+ Hits          9578      9586     +8     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/services/sort.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b5270...7420ba0. Read the comment docs.

@ghiscoding ghiscoding merged commit 5898c18 into master Jun 25, 2020
@ghiscoding ghiscoding deleted the feat/header-menu-resort-when-sort--columns-empty branch June 25, 2020 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants