Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • we were already checking for null value but undefined is another possibility, so now it checks for null/undefined in isValueChanged() method

- we were already checking for null value but undefined is another possibility, so now it checks for null/undefined in isValueChanged() method
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #516    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9589      9591     +2     
  Branches      3208      3344   +136     
==========================================
+ Hits          9589      9591     +2     
Impacted Files Coverage Δ
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/editors/floatEditor.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/editors/integerEditor.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/longTextEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/textEditor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53cc371...211a2b9. Read the comment docs.

@ghiscoding ghiscoding merged commit 0aaeb02 into master Jun 29, 2020
@ghiscoding ghiscoding deleted the bugfix/editor-undefined-values branch June 29, 2020 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants