Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

fix(frozen): hiding multiple columns when using pinning gets out of sync #684

Merged
merged 2 commits into from
Jan 26, 2021
Merged

fix(frozen): hiding multiple columns when using pinning gets out of sync #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aec545b
fix(frozen): hiding multiple columns when using pinning gets out of sync
ghiscoding Jan 26, 2021
223ab88
refactor: set shared grid option frozenColumns
ghiscoding Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/modules/angular-slickgrid/extensions/extensionUtility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export class ExtensionUtility {
if (frozenColumnIndex >= 0) {
const recalculatedFrozenColumnIndex = visibleColumns.findIndex(col => col.id === this.sharedService.frozenVisibleColumnId);
if (recalculatedFrozenColumnIndex >= 0 && recalculatedFrozenColumnIndex !== frozenColumnIndex) {
this.sharedService.gridOptions.frozenColumn = recalculatedFrozenColumnIndex;
this.sharedService.grid.setOptions({ frozenColumn: recalculatedFrozenColumnIndex });
}

Expand Down
3 changes: 2 additions & 1 deletion src/app/modules/angular-slickgrid/extensions/headerMenuExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ export class HeaderMenuExtension implements Extension {
// we need to do this because SlickGrid freezes by index and has no knowledge of the columns themselves
const frozenColumnIndex = this.sharedService.gridOptions.frozenColumn !== undefined ? this.sharedService.gridOptions.frozenColumn : -1;
if (frozenColumnIndex >= 0 && frozenColumnIndex >= columnIndex) {
this.sharedService.grid.setOptions({ frozenColumn: frozenColumnIndex - 1 });
this.sharedService.gridOptions.frozenColumn = frozenColumnIndex - 1;
this.sharedService.grid.setOptions({ frozenColumn: this.sharedService.gridOptions.frozenColumn });
}

// then proceed with hiding the column in SlickGrid & trigger an event when done
Expand Down