Ghostty not properly propagating light/dark preference to all surfaces #8906
Unanswered
iniw
asked this question in
Issue Triage
Replies: 1 comment 1 reply
-
|
Getting this exact same issue in the Helix editor after trying out their recently added support for light/dark mode. I am running the TIP release of ghostty. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Adding the following line to my printf '\e[?2031h'That said, this feels more like a workaround since it just forces DECSET 2031 on shell startup. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Issue Description
When changing my system's preferred color scheme, ghostty seems to only send the color palette update notification to some surfaces.
If the surface is bugged (not receiving the notification) it doesn't seem possible to fix it. The only way to get them back is to spawn new surfaces and hope that they will work properly.
I posted a video on the discord server showcasing the issue but it's too big for github so here's the link to the message: https://discord.com/channels/1005603569187160125/1320882404717625374/1420464937863479439
It shows two surfaces with helix (with two themes configured for light/dark mode) and the inspector opened. You can see that the bottom inspector's "Terminal IO" counter goes up by
187every time I switch themes and that the helix theme correctly changes. Meanwhile the top surface's counter stays still and the helix theme incorrectly stays the same.Surfaces don't seem to even be able to query light/dark mode preference at all when they're in this bugged state - setting my system theme to light mode then opening a new surface still opens helix in dark mode if the surface is bugged, since by default helix falls back to the dark theme when it can't query the terminal's preference.
Expected Behavior
All surfaces should properly have their light/dark mode preference propagated.
Actual Behavior
Only some surfaces, decided seemingly at random when the surface is opened, react to light/dark mode changes.
Reproduction Steps
Ghostty Logs
Logs of switching light/dark mode three times with two splits where the top one works and the bottom doesn't:
Ghostty Version
OS Version Information
MacOS Ventura (13.7.8)
(Linux only) Display Server
None
(Linux only) Desktop Environment/Window Manager
No response
Minimal Ghostty Configuration
Additional Relevant Configuration
No response
I acknowledge that:
```) on separate lines.Beta Was this translation helpful? Give feedback.
All reactions