update origin from upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"]" and ":" are not allowed either inside implicit link definitions.
The simpler style is also valid "Github Flavored Markdown" and it's simpler.
It's not fixed even after that PR was released, and I'm not really sure how we can avoid the current hack.
Using the Kramdown parser warnings includes warnings when implicit links have no definition, and it prints a better error, actually. Also, it probably warns about other stuff that can be interesting to know (and fix).
In the "Project (general)" section.
Using `__dir__` here is not fully equivalent since `__dir__` also resolves symlinks, but I think resolving symlinks is the best behavior.
Otherwise RSpec parallel spec and Cucumber parallel scenarios get the same command name, so they can overwrite each other.
Since we only test against latest devise.
This environment variable has been removed from the official docker images, so overriding it is no longer needed.
We might reevaluate this in the future, but for now I'm reverting while we figure out good enough alternatives so we can unblock releasing other improvements.
Due to force-push to the pending PR.
fixes: #5209
fix dependency detection
Rubocop consistency updates
Changing CSS rule as per @javierjulio suggestion
…ions in snippet (#5676)
Docker image runs as circleci user, which does not have priviledges to write to rubygems folders.
And overwrite the existing version.
Test against ruby 2.6
* Fix chandler reference again * Point to a tag instead
cancan project is deprecated and not updated since some years. Switch to `cancancan` (maintained version) to avoid confusion.
The old CanCan is not maintained since many years. Keep a reference only to the actively maintained version, in order to avoid confusion amongst new users.
`db` is a whole namespace, not a specific task.
Running `bin/rake local server` should automatically create a fresh new test application and migrate the db.
Capybara `3.14` contain numerous bug fixes and new features https://github.com/teamcapybara/capybara/blob/master/History.md#version-314
Fix db tasks on dev app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.