FSharpGlobals.fs not found on compile

[Unslinga]

Description:

When trying to compile the project, the file FSharpGlobals.fs appears to be missing, causing a compilation error.

Steps to Reproduce:

1. Download via PackageManager
2. Compile

Error:

error FS0225: Source file '/Users/xxx/Projects/yyy/Packages/com.gilzoide.fsharp/Scripts/FSharpGlobals.fs' could not be found [/Users/xxx/Projects/yyy/Assembly-FSharp.fsproj]

Proposed solution:

Copy FSharpGlobals.fs from
Library/PackageCache/com.gilzoide.fsharp@fcf652eff761/Scripts/FSharpGlobals.fs
to
Packages/com.gilzoide.fsharp/Scripts/FSharpGlobals.fs
on first setup.

Enviromnent

• Operating System: macOS
• Version: #1.0.0-preview3

[gilzoide]

Hey @Unslinga, thanks for the report.

Oh shoot, I totally forgot about that. Unity translates file paths from packages (like Packages/com.gilzoide.fsharp/Scripts/FSharpGlobals.fs) downloaded to the real paths inside PackageCache (like Library/PackageCache/com.gilzoide.fsharp@fcf652eff761/Scripts/FSharpGlobals.fs). I think we should translate those paths when generating the fsproj instead of copying stuff around as you suggested, because this would fix the same problem if any other packages decide to ship F# scripts as well.

[gilzoide]

For anyone interested in fixing this, I think changing the implementation of FSharpScript.AssetPath to do this asset path expansion would fix it.

[gilzoide]

@Unslinga I fixed this problem in version 1.0.0-preview4, could you please update the package version and confirm if it works?

[Unslinga]

@Unslinga I fixed this problem in version 1.0.0-preview4, could you please update the package version and confirm if it works?

It does not appear to have fixed it, and now I'm getting this error:

ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
Parameter name: i
System.Text.RegularExpressions.CaptureCollection.GetCapture (System.Int32 i) (at <a2eeb89b57774ce28311c7dc785d1a32>:0)
System.Text.RegularExpressions.CaptureCollection.get_Item (System.Int32 i) (at <a2eeb89b57774ce28311c7dc785d1a32>:0)
Gilzoide.FSharp.Editor.FSharpAssetPostprocessor.OnGeneratedSlnSolution (System.String path, System.String content) (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/FSharpAssetPostprocessor.cs:21)
System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <27bd554a9f0e46179afd19da1336e638>:0)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <27bd554a9f0e46179afd19da1336e638>:0)
System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) (at <27bd554a9f0e46179afd19da1336e638>:0)
Microsoft.Unity.VisualStudio.Editor.ProjectGeneration.InvokeAssetPostProcessorGenerationCallbacks (System.String name, System.String path, System.String content) (at ./Library/PackageCache/com.unity.ide.visualstudio@198cdf337d13/Editor/ProjectGeneration/ProjectGeneration.cs:445)
Microsoft.Unity.VisualStudio.Editor.ProjectGeneration.OnGeneratedSlnSolution (System.String path, System.String content) (at ./Library/PackageCache/com.unity.ide.visualstudio@198cdf337d13/Editor/ProjectGeneration/ProjectGeneration.cs:463)
Microsoft.Unity.VisualStudio.Editor.ProjectGeneration.SyncSolutionFileIfNotChanged (System.String path, System.String newContents) (at ./Library/PackageCache/com.unity.ide.visualstudio@198cdf337d13/Editor/ProjectGeneration/ProjectGeneration.cs:411)
Microsoft.Unity.VisualStudio.Editor.ProjectGeneration.SyncSolution (System.Collections.Generic.IEnumerable`1[T] assemblies) (at ./Library/PackageCache/com.unity.ide.visualstudio@198cdf337d13/Editor/ProjectGeneration/ProjectGeneration.cs:857)
Microsoft.Unity.VisualStudio.Editor.ProjectGeneration.SyncIfNeeded (System.Collections.Generic.IEnumerable`1[T] affectedFiles, System.Collections.Generic.IEnumerable`1[T] reimportedFiles) (at ./Library/PackageCache/com.unity.ide.visualstudio@198cdf337d13/Editor/ProjectGeneration/ProjectGeneration.cs:125)
Microsoft.Unity.VisualStudio.Editor.VisualStudioEditor.SyncIfNeeded (System.String[] addedFiles, System.String[] deletedFiles, System.String[] movedFiles, System.String[] movedFromFiles, System.String[] importedFiles) (at ./Library/PackageCache/com.unity.ide.visualstudio@198cdf337d13/Editor/VisualStudioEditor.cs:173)
UnityEditor.CodeEditorProjectSync.PostprocessSyncProject (System.String[] importedAssets, System.String[] addedAssets, System.String[] deletedAssets, System.String[] movedAssets, System.String[] movedFromAssetPaths) (at /Users/bokken/build/output/unity/unity/Editor/Mono/CodeEditor/CodeEditorProjectSync.cs:32)
UnityEditor.AssetPostprocessingInternal.PostprocessAllAssets (System.String[] importedAssets, System.String[] addedAssets, System.String[] deletedAssets, System.String[] movedAssets, System.String[] movedFromPathAssets, System.Boolean didDomainReload) (at /Users/bokken/build/output/unity/unity/Editor/Mono/AssetPostprocessor.cs:413)

I have looked into the function producing the error, OnGeneratedSlnSolution and I'd maybe recommend running a dotnet command line argument instead.

Also, /Users/bokken is not my username...

Update:

I tried building the fsharp project from the F# context menu, it gave me this error:

ArgumentNullException: Value cannot be null.
Parameter name: path
System.IO.Path.GetRelativePath (System.String relativeTo, System.String path, System.StringComparison comparisonType) (at <27bd554a9f0e46179afd19da1336e638>:0)
System.IO.Path.GetRelativePath (System.String relativeTo, System.String path) (at <27bd554a9f0e46179afd19da1336e638>:0)
Gilzoide.FSharp.Editor.FSharpScript.get_AssetPath () (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/FSharpScript.cs:16)
Gilzoide.FSharp.Editor.Internal.FSharpSettings+<>c.<get_ScriptPaths>b__5_0 (Gilzoide.FSharp.Editor.FSharpScript assetGuid) (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/FSharpSettings.cs:15)
System.Linq.Enumerable+SelectListIterator`2[TSource,TResult].MoveNext () (at <a7acc9325d424e1e88e649b810a910b8>:0)
System.Linq.Enumerable+WhereEnumerableIterator`1[TSource].MoveNext () (at <a7acc9325d424e1e88e649b810a910b8>:0)
Gilzoide.FSharp.Editor.FSharpProjectGenerator.GenerateFsproj () (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/FSharpProjectGenerator.cs:72)
Gilzoide.FSharp.Editor.FSharpBuilder.Build (Gilzoide.FSharp.Editor.FSharpPlatform platform, Gilzoide.FSharp.Editor.FSharpConfiguration configuration, System.Boolean async) (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/FSharpBuilder.cs:38)
Gilzoide.FSharp.Editor.Internal.Extensions.Forget (System.Threading.Tasks.Task task) (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/Internal/Extensions.cs:15)
UnityEngine.Debug:LogException(Exception)
Gilzoide.FSharp.Editor.Internal.<Forget>d__0:MoveNext() (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/Internal/Extensions.cs:23)
System.Runtime.CompilerServices.AsyncVoidMethodBuilder:Start(<Forget>d__0&)
Gilzoide.FSharp.Editor.Internal.Extensions:Forget(Task)
Gilzoide.FSharp.Editor.FSharpBuilder:BuildEditor() (at ./Library/PackageCache/com.gilzoide.fsharp@958c3d106cee/Editor/FSharpBuilder.cs:68)

[gilzoide]

I have looked into the function producing the error, OnGeneratedSlnSolution and I'd maybe recommend running a dotnet command line argument instead.

You mean to add the fsproj to the solution? I'm not very well versed in .NET projects, but it may as well be a better idea then editing the file manually 🤔

Also, /Users/bokken is not my username...

"bokken" is the user name of the build machine Unity uses, if you pay attention you'll see it a lot in stack traces and other debug logs from the editor.

[gilzoide]

ArgumentNullException: Value cannot be null.
Parameter name: path

Ok, that one is new. For an asset path to be null, the ScritpableObject likely haven't been saved yet or something like that 🤔

[Unslinga]

ArgumentNullException: Value cannot be null.
Parameter name: path

Ok, that one is new. For an asset path to be null, the ScritpableObject likely haven't been saved yet or something like that 🤔

This one worked for me: public string AssetPath => Path.GetFullPath(AssetDatabase.GetAssetPath(this));

[Unslinga]

You mean to add the fsproj to the solution? I'm not very well versed in .NET projects, but it may as well be a better idea then editing the file manually 🤔

you can use dotnet sln add "Assembly-FSharp.fsproj", I see that you already have a ProcessRunner

[Unslinga]

Has this been completed?

[gilzoide]

@Unslinga No, vmenge just closed the PR without saying anything. The fix hasn't been merged yet.

[Unslinga]

@gilzoide
I can create a PR for implementing the dotnet commands and fixing the issue.

I suggest not adding sh/pws scripts for installing dotnet, because that type of functionality may lead to security issues. I think Unity already provides installer functionality for dotnet if that is missing.