Fixed bug when using forceLongFormat on gitDescribe #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue had no effect)
ktoso
added a commit
that referenced
this pull request
Apr 20, 2014
Fixed bug when using forceLongFormat on gitDescribe
Collaborator
|
Looks good, thanks a lot Georg. Happy easter! |
Contributor
Author
|
Will do! Thanks! Happy easter! |
Collaborator
|
// deployed snapshot 2.1.10 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting "forceLongFormat" to true in the "gitDescribe" section of the plugin configuration does not have the desired effect and will not force the long format of the "git.commit.id.describe" property. I've created two new test methods in GitCommitIdMojoIntegrationTest that exposes the bug and made changes that should fix the bug.
This pull request also includes two changes to two log statements in DescribeCommand. The first fixes a bug and the second adds some extra info.