Skip to content

Avoid NPE as discussed in #57 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2015
Merged

Avoid NPE as discussed in #57 #182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5740b7
Avoid NPE as discussed in https://github.com/ktoso/maven-git-commit-i…
Apr 9, 2015
3139543
reword you've -> you have
Apr 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/java/pl/project13/maven/git/JGitProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,16 @@ protected String getBuildAuthorEmail() {
protected void prepareGitToExtractMoreDetailedReproInformation() throws MojoExecutionException {
try {
// more details parsed out bellow
Ref HEAD = git.getRef(Constants.HEAD);
if (HEAD == null) {
throw new MojoExecutionException("Could not get HEAD Ref, are you sure you've set the dotGitDirectory property of this plugin to a valid path?");
Ref head = git.getRef(Constants.HEAD);
if (head == null) {
throw new MojoExecutionException("Could not get HEAD Ref, are you sure you have set the dotGitDirectory property of this plugin to a valid path?");
}
revWalk = new RevWalk(git);
headCommit = revWalk.parseCommit(HEAD.getObjectId());
ObjectId headObjectId = head.getObjectId();
if(headObjectId == null){
throw new MojoExecutionException("Could not get HEAD Ref, are you sure you have some commits in the dotGitDirectory?");
}
headCommit = revWalk.parseCommit(headObjectId);
revWalk.markStart(headCommit);
} catch (MojoExecutionException e) {
throw e;
Expand Down